Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Mar 10, 2014

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iit

@pavelgj
Copy link
Contributor

pavelgj commented Mar 11, 2014

Can you also add this test

  it('should not call reaction fn when destroyed', () {
    var testScope = scope.createChild({});
    bool called = false;
    testScope.watch('items', (_, __) {
      called = true;
    });
    testScope.destroy();
    scope.apply();
    expect(called).toBeFalsy();
  });

Otherwise lgtm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space here and below

mhevery added a commit to mhevery/angular.dart that referenced this pull request Mar 11, 2014
@mhevery mhevery closed this in 1ba5bef Mar 11, 2014
@mhevery mhevery deleted the mem-leak branch March 11, 2014 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants